haskell/yesod
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1766 from ivanbakel/fix-meta-typo

Browse Source 
Fix typo in how description meta tags are laid out
This commit is contained in:
Michael Snoyman 2022-04-25 05:15:55 +03:00 committed by GitHub
commit 0a273d5aae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
yesod-core/ChangeLog.md
View File

@ -1,5 +1,9 @@
# ChangeLog for yesod-core # ChangeLog for yesod-core
## 1.6.23.1
* Fix typo in creation of the description `<meta>` tag in `defaultLayout`. [#1766](https://github.com/yesodweb/yesod/pull/1766)
## 1.6.23 ## 1.6.23
* Add idempotent versions of `setDescription`, `setDescriptionI`. These functions * Add idempotent versions of `setDescription`, `setDescriptionI`. These functions

2
yesod-core/src/Yesod/Core/Class/Yesod.hs
View File

@ -88,7 +88,7 @@ class RenderRoute site => Yesod site where
<head> <head>
<title>#{pageTitle p} <title>#{pageTitle p}
$maybe description <- pageDescription p $maybe description <- pageDescription p
<meta type="description" content="#{description}"> <meta name="description" content="#{description}">
^{pageHead p} ^{pageHead p}
<body> <body>
$forall (status, msg) <- msgs $forall (status, msg) <- msgs

2
yesod-core/test/YesodCoreTest/Meta.hs
View File

@ -48,7 +48,7 @@ metaTest = describe "Setting page metadata" $ do
res <- request defaultRequest res <- request defaultRequest
{ pathInfo = ["desc"] { pathInfo = ["desc"]
} }
assertBody "<!DOCTYPE html>\n<html><head><title></title><meta type=\"description\" content=\"Second description\"></head><body></body></html>" res assertBody "<!DOCTYPE html>\n<html><head><title></title><meta name=\"description\" content=\"Second description\"></head><body></body></html>" res
runner :: Session () -> IO () runner :: Session () -> IO ()
runner f = toWaiAppPlain App >>= runSession f runner f = toWaiAppPlain App >>= runSession f

2
yesod-core/yesod-core.cabal
View File

@ -1,5 +1,5 @@
name: yesod-core name: yesod-core
version: 1.6.23 version: 1.6.23.1
license: MIT license: MIT
license-file: LICENSE license-file: LICENSE
author: Michael Snoyman <michael@snoyman.com> author: Michael Snoyman <michael@snoyman.com>