haskell/cryptonite
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Warn about non-uniform distribution with QuickCheck

Browse Source
This commit is contained in:
Olivier Chéron 2020-01-04 10:58:22 +01:00
parent 17879cbecd
commit 1f6ed5711c
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Crypto/Random.hs
View File

@ -80,6 +80,10 @@ drgNewSeed (Seed seed) = initialize seed
-- --
-- It can also be used in other contexts provided the input -- It can also be used in other contexts provided the input
-- has been properly randomly generated. -- has been properly randomly generated.
--
-- Note that the @Arbitrary@ instance provided by QuickCheck for 'Word64' does
-- not have a uniform distribution. It is often better to use instead
-- @arbitraryBoundedRandom@.
drgNewTest :: (Word64, Word64, Word64, Word64, Word64) -> ChaChaDRG drgNewTest :: (Word64, Word64, Word64, Word64, Word64) -> ChaChaDRG
drgNewTest = initializeWords drgNewTest = initializeWords

2
tests/Utils.hs
View File

@ -19,7 +19,7 @@ newtype TestDRG = TestDRG (Word64, Word64, Word64, Word64, Word64)
deriving (Show,Eq) deriving (Show,Eq)
instance Arbitrary TestDRG where instance Arbitrary TestDRG where
arbitrary = TestDRG `fmap` arbitrary arbitrary = TestDRG `fmap` arbitrary -- distribution not uniform
withTestDRG (TestDRG l) f = fst $ withDRG (drgNewTest l) f withTestDRG (TestDRG l) f = fst $ withDRG (drgNewTest l) f