fraport/fradrive-old
Archived
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(displayable): removed resolved TODOs

Browse Source
This commit is contained in:
Sarah Vaupel 2019-07-03 10:05:53 +02:00
parent 6aaa2d2093
commit b0ed911849
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Handler/Utils/Table/Cells.hs
View File

@ -237,7 +237,7 @@ submissionCell crse shn sid =
csh = crse ^. _3 csh = crse ^. _3
mkCid = encrypt sid mkCid = encrypt sid
mkRoute cid = CSubmissionR tid ssh csh shn cid SubShowR mkRoute cid = CSubmissionR tid ssh csh shn cid SubShowR
mkText = toWgt -- display2widget -- TODO: replace with toWgt once there is a ToMarkup instance for CryptoIDs mkText = toWgt
in anchorCellM' mkCid mkRoute mkText in anchorCellM' mkCid mkRoute mkText
correctorStateCell :: IsDBTable m a => SheetCorrector -> DBCell m a correctorStateCell :: IsDBTable m a => SheetCorrector -> DBCell m a

7
src/Model.hs
View File

@ -53,15 +53,10 @@ submissionRatingDone :: Submission -> Bool
submissionRatingDone Submission{..} = isJust submissionRatingTime submissionRatingDone Submission{..} = isJust submissionRatingTime
-- ToMarkup instances for displaying certain database primary keys -- ToMarkup instances for displaying certain database primary keys
-- TODO: work in progress, populate with more instances
-- TODO: is there a better place for this? -- TODO: is there a better place for this?
instance ToMarkup (Key School) where instance ToMarkup (Key School) where
toMarkup = toMarkup . unSchoolKey toMarkup = toMarkup . unSchoolKey
instance ToMarkup (Key Term) where instance ToMarkup (Key Term) where
toMarkup = toMarkup . termToText . unTermKey toMarkup = toMarkup . termToText . unTermKey
-- TODO: unfinished
-- instance ToMarkup (Key Submission) where
-- toMarkup = toMarkup . unSubmissionKey