fix(avs): fix tests (do not exit with failure on empty avs config)

src/Application.hs

@@ -345,14 +345,14 @@ makeFoundation appSettings''@AppSettings{..} = do
           handleIf isBucketExists (const $ return ()) $ Minio.makeBucket appUploadTmpBucket Nothing
         return conn
 
-      appAvsQuery <- do
+      appAvsQuery <- case appAvsConf of 
-        manager <- newManagerSettings $ mkManagerSettings (def { settingDisableCertificateValidation = True }) Nothing
-        case appAvsConf of 
         Nothing -> do
           $logErrorS "avsPrepare" "appAvsConfig is empty, i.e. invalid AVS configuration settings."
-            liftIO exitFailure
+          return Nothing
+          -- liftIO exitFailure
         Just avsConf -> do
           -- TODO: consider using Servant.Client.Core.BaseUrl.Instances.parseBaseUrl' within Settings already at Startup!
+          manager <- newManagerSettings $ mkManagerSettings (def { settingDisableCertificateValidation = True }) Nothing
           let avsServer = BaseUrl 
                             { baseUrlScheme = Https
                             , baseUrlHost = avsHost avsConf
@@ -365,7 +365,7 @@ makeFoundation appSettings''@AppSettings{..} = do
                           }
               (avsPersonSearch :<|> avsPersonStatus) = client avsApi avsAuth
               runQuery query = runClientM query $ mkClientEnv manager avsServer
-            return AvsQuery
+          return $ Just AvsQuery
             { avsQueryPerson = liftIO . runQuery . avsPersonSearch
             , avsQueryStatus = liftIO . runQuery . avsPersonStatus
             }

src/Foundation/Type.hs

@@ -99,7 +99,7 @@ data UniWorX = UniWorX
     , appPersonalisedSheetFilesSeedKey :: PersonalisedSheetFilesSeedKey
     , appVolatileClusterSettingsCache :: TVar VolatileClusterSettingsCache
     , appStartTime         :: UTCTime -- for Status Page
-    , appAvsQuery          :: AvsQuery
+    , appAvsQuery          :: Maybe AvsQuery
     } deriving (Typeable)
 
 makeLenses_ ''UniWorX

src/Handler/Admin/Avs.hs

@@ -54,8 +54,10 @@ validateAvsStatusQuery = do
 getAdminAvsR, postAdminAvsR :: Handler Html
 getAdminAvsR = postAdminAvsR
 postAdminAvsR = do
-  AvsQuery{..} <- getsYesod $ view _appAvsQuery
+  mAvsQuery <- getsYesod $ view _appAvsQuery
-
+  case mAvsQuery of
+    Nothing -> return mempty
+    Just AvsQuery{..} -> do
       ((presult, pwidget), penctype) <- runFormPost $ makeAvsPersonForm Nothing
 
       let procFormPerson fr = do