fraport/fradrive-old
Archived
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(avs): ensure audit log usage for avs problem resolution

Browse Source
This commit is contained in:
Steffen Jost 2023-01-18 18:04:30 +01:00
parent 06f283be7e
commit 53499fd637
1 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/Handler/Admin/Avs.hs
View File

@ -389,28 +389,12 @@ getProblemAvsSynchR = do
mkind = if oks < no_req then Warning else Success mkind = if oks < no_req then Warning else Success
addMessageI mkind $ MsgAvsSetLicences aLic oks no_req addMessageI mkind $ MsgAvsSetLicences aLic oks no_req
redirect ProblemAvsSynchR -- reload to update all tables redirect ProblemAvsSynchR -- reload to update all tables
procRes alic (LicenceTableRevokeFDriveData, apids) = do
procRes alic (LicenceTableRevokeFDriveData, selectedUsers) = do
runDB $ do runDB $ do
qId <- getKeyBy404 $ UniqueQualificationAvsLicence $ Just alic qId <- getKeyBy404 $ UniqueQualificationAvsLicence $ Just alic
uas <- selectList [UserAvsPersonId <-. Set.toList apids] [] forM_ selectedUsers $ upsertQualificationUser qId nowaday $ pred nowaday
let uids = view _userAvsUser <$> uas addMessageI Success $ MsgRevokeFraDriveLicences alic oks
endday = pred nowaday
crits = [QualificationUserQualification ==. qId, QualificationUserUser <-. uids]
oks <- fromIntegral <$> updateWhereCount crits [QualificationUserValidUntil =. endday, QualificationUserLastRefresh =. nowaday]
qus <- selectList crits []
forM_ qus $ \qu ->
audit TransactionQualificationUserEdit
{ transactionQualificationUser = qu ^. _entityKey
, transactionQualification = qId -- qu ^. _qualificationUserQualification
, transactionUser = qu ^. _qualificationUserUser
, transactionQualificationValidUntil = endday -- qu ^. _qualificationUserValidUntil
}
if oks /= length qus || oks /= Set.size apids
then do
$logErrorS "AVS" $ "Revoke FRADrive licences discrepancy! Requested: " <> tshow (Set.size apids) <> " Updated: " <> tshow oks <> " Found: " <> tshow (length qus)
liftHandler $ addMessageI Error $ MsgRevokeFraDriveLicences alic oks
else
liftHandler $ addMessageI Success $ MsgRevokeFraDriveLicences alic oks
redirect ProblemAvsSynchR -- must be outside runDB redirect ProblemAvsSynchR -- must be outside runDB
procRes _alic (LicenceTableGrantFDriveData{..}, apids ) = do procRes _alic (LicenceTableGrantFDriveData{..}, apids ) = do