fix(exams): allow occurrences after exam end

src/Handler/Exam/Form.hs

@@ -346,7 +346,7 @@ validateExam = do
   forM_ efOccurrences $ \ExamOccurrenceForm{..} -> do
     guardValidation (MsgExamOccurrenceEndMustBeAfterStart eofName) $ NTop eofEnd >= NTop (Just eofStart)
     guardValidation (MsgExamOccurrenceStartMustBeAfterExamStart eofName) $ NTop (Just eofStart) >= NTop efStart
-    guardValidation (MsgExamOccurrenceEndMustBeBeforeExamEnd eofName) $ NTop eofEnd <= NTop efEnd
+    warnValidation  (MsgExamOccurrenceEndMustBeBeforeExamEnd eofName) $ NTop eofEnd <= NTop efEnd
 
   forM_ [ (a, b) | a <- Set.toAscList efOccurrences, b <- Set.toAscList efOccurrences, b > a ] $ \(a, b) -> do
     eofRange' <- formatTimeRange SelFormatDateTime (eofStart a) (eofEnd a)

src/Utils/Form.hs

@@ -4,7 +4,7 @@
 
 module Utils.Form where
 
-import ClassyPrelude.Yesod hiding (addMessage, cons, Proxy(..), identifyForm)
+import ClassyPrelude.Yesod hiding (addMessage, addMessageI, cons, Proxy(..), identifyForm)
 import Yesod.Core.Instances ()
 import Settings
 
@@ -936,7 +936,7 @@ guardValidation :: ( MonadHandler m
                 => msg -- ^ Message describing violation
                 -> Bool -- ^ @False@ iff constraint is violated
                 -> FormValidator r m ()
-guardValidation msg isValid = when (not isValid) $ tellValidationError msg
+guardValidation msg isValid = unless isValid $ tellValidationError msg
 
 guardValidationM :: ( MonadHandler m
                     , RenderMessage (HandlerSite m) msg
@@ -944,6 +944,15 @@ guardValidationM :: ( MonadHandler m
                  => msg -> m Bool -> FormValidator r m ()
 guardValidationM = (. lift) . (=<<) . guardValidation
 
+
+warnValidation ::  ( MonadHandler m
+                   , RenderMessage (HandlerSite m) msg
+                   )
+                => msg -- ^ Message describing violation
+                -> Bool -- ^ @False@ iff constraint is violated
+                -> FormValidator r m ()
+warnValidation msg isValid = unless isValid $ addMessageI Warning msg
+
 -----------------------
 -- Form Manipulation --
 -----------------------