fraport/fradrive-old
Archived
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(audit): revise audit for corrector submission edits

Browse Source
This commit is contained in:
Sarah Vaupel 2019-09-04 15:30:19 +02:00
parent 99cd37c5e0
commit 2f9f0535af
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Audit/Types.hs
View File

@ -62,7 +62,6 @@ data Transaction
, transactionSheet :: SheetId , transactionSheet :: SheetId
} }
-- TODO: audit work in progress
| TransactionSubmissionUserEdit | TransactionSubmissionUserEdit
{ transactionSubmission :: SubmissionId { transactionSubmission :: SubmissionId
, transactionUser :: UserId , transactionUser :: UserId

7
src/Handler/Corrections.hs
View File

@ -924,10 +924,12 @@ postCorrectionsCreateR = do
Arbitrary maxSize -> do Arbitrary maxSize -> do
subId <- insert submissionPrototype subId <- insert submissionPrototype
void . insert $ SubmissionEdit uid now subId void . insert $ SubmissionEdit uid now subId
audit $ TransactionSubmissionEdit subId sid
insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser
{ submissionUserUser = sheetPseudonymUser { submissionUserUser = sheetPseudonymUser
, submissionUserSubmission = subId , submissionUserSubmission = subId
} }
forM_ spGroup $ \SheetPseudonym{sheetPseudonymUser} -> audit $ TransactionSubmissionUserEdit subId sheetPseudonymUser
when (genericLength spGroup > maxSize) $ when (genericLength spGroup > maxSize) $
addMessageI Warning $ MsgSheetGroupTooLarge sheetGroupDesc addMessageI Warning $ MsgSheetGroupTooLarge sheetGroupDesc
RegisteredGroups -> do RegisteredGroups -> do
@ -949,7 +951,7 @@ postCorrectionsCreateR = do
{ submissionUserUser = sheetUser { submissionUserUser = sheetUser
, submissionUserSubmission = subId , submissionUserSubmission = subId
} }
audit $ TransactionSubmissionUserEdit subId uid forM_ groupUsers $ audit . TransactionSubmissionUserEdit subId
when (null groups) $ when (null groups) $
addMessageI Warning $ MsgSheetNoRegisteredGroup sheetGroupDesc addMessageI Warning $ MsgSheetNoRegisteredGroup sheetGroupDesc
| length groups < 2 | length groups < 2
@ -962,11 +964,12 @@ postCorrectionsCreateR = do
NoGroups -> do NoGroups -> do
subId <- insert submissionPrototype subId <- insert submissionPrototype
void . insert $ SubmissionEdit uid now subId void . insert $ SubmissionEdit uid now subId
audit $ TransactionSubmissionEdit subId sid
insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser
{ submissionUserUser = sheetPseudonymUser { submissionUserUser = sheetPseudonymUser
, submissionUserSubmission = subId , submissionUserSubmission = subId
} }
audit $ TransactionSubmissionUserEdit subId uid forM_ spGroup $ \SheetPseudonym{sheetPseudonymUser} -> audit $ TransactionSubmissionUserEdit subId sheetPseudonymUser
when (length spGroup > 1) $ when (length spGroup > 1) $
addMessageI Warning $ MsgSheetNoGroupSubmission sheetGroupDesc addMessageI Warning $ MsgSheetNoGroupSubmission sheetGroupDesc
when allDone $ when allDone $