fraport/fradrive-old
Archived
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(exam-bonus): avoid divide by zero if all sheets are bonus

Browse Source 
Fixes #671
This commit is contained in:
Gregor Kleen 2021-02-15 12:14:43 +01:00
parent 1cd79d35e2
commit 0fd7e86695
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Handler/Utils/Exam.hs
View File

@ -170,6 +170,7 @@ examResultBonus bonusRule bonusPossible bonusAchieved = case bonusRule of
scalePasses :: Integer -> Rational scalePasses :: Integer -> Rational
-- ^ Rescale passes so count of all sheets with pass is worth as many points as sum of all sheets with points -- ^ Rescale passes so count of all sheets with pass is worth as many points as sum of all sheets with points
scalePasses passes scalePasses passes
| pointsPossible <= 0, passesPossible <= 0 = 1 -- This arbitrarily identifies a pass as being worth one point if all sheets are `Bonus`; maybe weird
| pointsPossible <= 0 = toRational mPoints / fromInteger passesPossible | pointsPossible <= 0 = toRational mPoints / fromInteger passesPossible
| passesPossible <= 0 = 0 | passesPossible <= 0 = 0
| otherwise = fromInteger passes / fromInteger passesPossible * toRational pointsPossible | otherwise = fromInteger passes / fromInteger passesPossible * toRational pointsPossible